Google Git
Sign in
chromium / chromium / src / b46896f17569141705e80681f641bc0d3db3a7dd
commitb46896f17569141705e80681f641bc0d3db3a7dd[log] [tgz]
authorTina Wang <tinazwang@google.com>Thu May 26 21:00:18 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu May 26 21:00:18 2022
treec0eb271ae70b138b497011fb255a8442e38ee264
parent1c84813ee42b1657ac3c29f8e16c153ebcb14c4f [diff]
[WebChannels] Fix FollowJavaScriptFeature::HandleResponse crash

It crashes because -[NSArray addObject:] can't take a nil, and rarely
sometime the -[NSURL URLWithString:] returns nil because there are
non-ASCII characters in the string. So we need to check if url is a
valid NSURL object before we add it to the NSArray.

(cherry picked from commit 17ae670382d8ad3c4203f9a28f036f498767312c)

Bug: 1328017
Change-Id: I073e6b264d4278c480b5e1270bf64b42ff90be7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3665517
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1007293}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3669470
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Auto-Submit: Tina Wang <tinazwang@chromium.org>
Cr-Commit-Position: refs/branch-heads/5060@{#277}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
2 files changed
tree: c0eb271ae70b138b497011fb255a8442e38ee264
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.