Google Git
Sign in
chromium / chromium / src / b4917b45510132b51f88bd885c02e0f7cec5be0e
commitb4917b45510132b51f88bd885c02e0f7cec5be0e[log] [tgz]
authorXinghui Lu <xinghuilu@chromium.org>Thu Jul 21 01:34:34 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jul 21 01:34:34 2022
treee3572af92d2ba743d22719d558d6bbb830b0dbdc
parent52ff0aa53acc18400655e6eb3796c7494ccf6d5f [diff]
[DownloadBubble] Introduce downloads.setUiOptions extension API

Introduce downloads.setUiOptions as a replacement of
downloads.setShelfEnabled, since download UX is moving from shelf to
a bubble.

The initial implementation added in this CL is forked from
DownloadsSetShelfEnabledFunction::Run(), so it only controls the
download shelf. The support of download bubble will be added in a
follow-up CL.

This CL adds a new downloads.ui permission, which is required to use
the new API. The new permission does not trigger a warning, same as in
the old downloads.shelf permission.

Bug: 1340400
Change-Id: Ia5e77ebf679875611da70f0384150469a7277b66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3760432
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1026578}
11 files changed
tree: e3572af92d2ba743d22719d558d6bbb830b0dbdc
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.