commit | b4a830f56a4f4d033f88b7b649b0378c7e00ad1c | [log] [tgz] |
---|---|---|
author | Francois Pierre Doray <fdoray@chromium.org> | Wed Feb 09 15:24:33 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Feb 09 15:24:33 2022 |
tree | ee8db3cefad0ddd1b15a09e4fda63daaa93243dd | |
parent | 36558f6c21ee049b2274e232f41ff6485a7f9f5d [diff] |
Revert "[Private Network Access] Remove `addressSpace` from IDL." This reverts commit 4f3c5a82c3fe14f9108b4fd758c812ab6f01f34c. Reason for revert: compile failure [62150/91044] CXX obj/third_party/blink/renderer/bindings/core/v8/v8/v8_address_space.o FAILED: obj/third_party/blink/renderer/bindings/core/v8/v8/v8_address_space.o ../../buildtools/reclient/rewrapper -cfg=../../buildtools/reclient_cfgs/chromium-browser-clang/rewra...(too long) clang++: error: no such file or directory: 'gen/third_party/blink/renderer/bindings/core/v8/v8_address_space.cc' clang++: error: no input files Original change's description: > [Private Network Access] Remove `addressSpace` from IDL. > > This attribute has been removed from the specification for a long time: > https://github.com/WICG/private-network-access/issues/21 > > Also remove the old CORS-RFC1918 web tests exercising this attribute, as > well as the virtual test suites running only these tests. One of these > tests was flaky, so this CL also fixed crbug.com/1267552. > > Bug: chromium:1204028 > Change-Id: I47eb8c0d0eeac838ec9a584c8505459347baac6f > Fixed: chromium:1267552 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3442962 > Auto-Submit: Titouan Rigoudy <titouan@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Commit-Queue: Stephen Chenney <schenney@chromium.org> > Cr-Commit-Position: refs/heads/main@{#968916} Bug: chromium:1204028 Change-Id: I5a7b1bd4696d7328a9de511ef62c0c3fdb83f3a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3450190 Owners-Override: Francois Pierre Doray <fdoray@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Francois Pierre Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/main@{#968922}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.