| commit | b56bcb92d69c4f4fe46a224744bcf2f8f5b5164a | [log] [tgz] |
|---|---|---|
| author | dpapad <dpapad@chromium.org> | Wed May 14 01:29:07 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed May 14 01:29:07 2025 |
| tree | abd6b9dfbd3fad9f5d21e736217c7fce9c6ebf8a | |
| parent | 02a701f662f78fd023992c453cfb41657f6644a2 [diff] |
PrintPreview: Replace model.set() with non-Polymer alternative in tests.
Specifically:
- Replace calls to `model.set('settings.<settingName>.value', ...)`
with `model.setSetting()`. In a few cases where the tests expected
the `<settingName>.setFromUi` to be false, leverage the `noSticky`
optional boolean parameter.
- Replace calls to `model.set('settings.<settingName>.available', ...)`
with a newly exposed `model.setSettingAvailableForTesting()`.
Remaining `model.set(...)` calls will be replaced in follow-ups.
This is in preparation of migrating print-preview-model off Polymer,
where `model.set()` will be removed and the `settings` object will no
longer be publicly exposed.
Bug: 410607166
Change-Id: I3d3c0624b9cfee793488651b0c29f8fa8674fabc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6538367
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1459831}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.