Fix upload save IBAN metrics for kAccept case This CL fixes an issue where the "upload save IBAN accepted" case was not being logged. The root cause was that current_bubble_type_ was being set to IbanBubbleType::kUploadInProgress right after the user clicked the save button. However, the logging logic for the bubble closing reason did not account for kUploadInProgress in upload scenarios. This change ensures that the accepted upload case is properly logged. This issue is introduced at http://crrev.com/c/5983935 when loading effect is added to the upload bubble. Bug: b:413338121 Change-Id: Id04bf41f27e26522245de203c233477a5c88403d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6488936 Commit-Queue: Qihui Zhao <qihuizhao@google.com> Reviewed-by: Olivia Saul <jsaul@google.com> Reviewed-by: Jan Keitel <jkeitel@google.com> Cr-Commit-Position: refs/heads/main@{#1451791}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.