commit | b5890cb4e7f0c52f6e09cf857cf85d3f5efae923 | [log] [tgz] |
---|---|---|
author | Alison Gale <agale@chromium.org> | Wed Feb 28 16:56:19 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Feb 28 16:56:19 2024 |
tree | 3083eb223927ec80a0fc10066016b0fa2dae75b4 | |
parent | 96d76c298591114922a9dad6a797cfa1f19e8f89 [diff] |
Remove redundant first run check around the default browser prompt Added braces on the caller code per current style guide which helped this change include infobar_utils.cc. Within infobar_utils.cc we only call ShowDefaultBrowserPrompt() if first run is kNo. This means that the first run welcome page shouldn't be visible on any of the web contents. I looked through old code and it looks like earlier there was conditional logic on the first run check in the original location of infobar_utils but now there isn't can case where it can be a first run and we show the info bar. Bug: 326134198 Change-Id: I7d44acf29342c4ee386c29e57982ca6e0cfe0c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5319231 Commit-Queue: Alison Gale <agale@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/main@{#1266464}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.