Google Git
Sign in
chromium / chromium / src / b59531987e9ae5bb9601816c3c5283df2e9808f9
commitb59531987e9ae5bb9601816c3c5283df2e9808f9[log] [tgz]
authorNoémie St-Onge <noemies@google.com>Fri Apr 21 19:32:49 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Apr 21 19:32:49 2023
tree8b26bda5d4cba1629ff00a088c0796fb4d94faf5
parentfdd93cdb7af14f9eb10820fe0ec17c79dbc4f9de [diff]
[iOS] Fix tests that are failing when the Password Checkup feature is on

In order to enable the kIOSPasswordCheckup feature on Canary, we wanted
to make sure that all tests are succeeding when the feature is on. This
CL fixes the tests that were not passing with the feature enabled.

Failures:
https://ci.chromium.org/ui/p/chrome/builders/try/ipad-simulator/b8783264715332696417/test-results?q=ExactID%3Aninja%3A%2F%2Fios%2Fchrome%2Ftest%2Fearl_grey2%3Aios_chrome_settings_eg2tests_module%2FPasswordManagerGroupingDisabledTestCase%2FtestDeletePasswordIssue+VHash%3A63b5636d18cef49a&clean=&sortby=&groupby=

https://ci.chromium.org/ui/p/chrome/builders/try/ipad-simulator/b8783264866062764945/test-results?q=ExactID%3Aninja%3A%2F%2Fios%2Fchrome%2Ftest%2Fearl_grey2%3Aios_chrome_settings_eg2tests_module%2FPasswordManagerTestCase%2FtestDeletePasswordIssue+VHash%3A63b5636d18cef49a&clean=&sortby=&groupby=

https://ci.chromium.org/ui/p/chrome/builders/try/ipad-simulator/b8783264866062764945/test-results?q=ExactID%3Aninja%3A%2F%2Fios%2Fchrome%2Ftest%3Aios_chrome_unittests%2FPasswordIssuesTableViewControllerTest.TestPasswordIssue+VHash%3A274a8dc883064306&clean=&sortby=&groupby=

https://ci.chromium.org/ui/p/chrome/builders/try/ipad-simulator/b8783264866062764945/test-results?q=ExactID%3Aninja%3A%2F%2Fios%2Fchrome%2Ftest%3Aios_chrome_unittests%2FPasswordIssuesTableViewControllerTest.TestModel+VHash%3A4630049702dabc04&clean=&sortby=&groupby=

Bug: 1406540
Change-Id: Ie8182a9a76de61f9a8e698a1a381718529f082af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4455183
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Noémie St-Onge <noemies@google.com>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1133973}
2 files changed
tree: 8b26bda5d4cba1629ff00a088c0796fb4d94faf5
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.