| commit | b59764323fdf4b4408045662b51b9c8a6ff3151d | [log] [tgz] |
|---|---|---|
| author | Amanda Lin Dietz <aldietz@google.com> | Wed Dec 18 19:07:54 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Dec 18 19:07:54 2024 |
| tree | 62e43216e5f55a4adb97728b8ad3b85b310dfc4f | |
| parent | 8bb05339e0940c466532497216fa34f23f306741 [diff] |
Reland "[FaceGaze] Add confirmation dialogs for feature/cursor/actions buttons" This is a reland of commit c41380632ca608590fb12955865d759c8ecb3dd9 The original commit was reverted under suspicion of introducing test failures on linux-chromeos-dbg, but the test failures persisted after revert and were definitively traced back to a different commit. Relanding this CL as-is. crbug.com/384012319 filed for the test failures. Bug: 371199351 Original change's description: > [FaceGaze] Add confirmation dialogs for feature/cursor/actions buttons > > * Show standard confirmation dialog when feature is toggled off. > * Show standard confirmation dialog when cursor control is toggled off. > * Show standard confirmation dialog when actions are toggled off. > * To enable user to use FaceGaze to interact with the dialog, > add a set of sentinel prefs to indicate when users have toggled > the button off. > * To enable JS to force feature off without showing a dialog, > add a sentinel pref for showing a confirmation dialog that is > set to false when FaceGaze is forcing the feature off. > * Update all JS to only interact with the set of sentinel prefs. > * Add tests. > * Leave cursor/actions strings as translateable=false for now. > > Design doc: > https://docs.google.com/document/d/1ULHXI_QK6ET1Inyrm_9DrIpiecVFc3Z7kyyv6cs0oJ0/edit?usp=sharing > > Screenshots: > https://screenshot.googleplex.com/3f6ir9GbJC7zd5q > https://screenshot.googleplex.com/ra4nbokD8K4Cpub > https://screenshot.googleplex.com/6fd2gzZvx8Gmg3W > > Change-Id: Iccb932657e9613cef670f2638e5dfa0794d0e3db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042086 > Reviewed-by: Akihiro Ota <akihiroota@chromium.org> > Commit-Queue: Amanda Lin Dietz <aldietz@google.com> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1395618} Change-Id: I2a6ff4a9e251c86b66ffd36af778e06531423ce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6101831 Reviewed-by: James Cook <jamescook@chromium.org> Auto-Submit: Amanda Lin Dietz <aldietz@google.com> Reviewed-by: Akihiro Ota <akihiroota@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Amanda Lin Dietz <aldietz@google.com> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/main@{#1398090}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.