Google Git
Sign in
chromium / chromium / src / b5a04980ee4783b0a99e6a317804a174c8dbb51e
commitb5a04980ee4783b0a99e6a317804a174c8dbb51e[log] [tgz]
authorAlison Maher <almaher@microsoft.com>Fri Jan 24 19:09:41 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jan 24 19:09:41 2025
treee46c85acf268064eb1e46c016f0d3f60d29040e2
parentddc5e1ae026c074fe02b98f4a891a301a77e00e4 [diff]
Update CHECK in AXObject::UpdateCachedAttributeValuesIfNeeded

In AXObject::UpdateCachedAttributeValuesIfNeeded() we CHECK that
the lifecycle state allows immediate tree updates. This CHECK is
being hit by customers in 133 and 134.

Demote to a non-fatal check while the root cause is further
investigated and understood.

Also add some extra logging of both the object and its parent
chain to aid in further investigation.

Bug: 382104886
Change-Id: I320670574168f00b91240cfe6a441ec10de5ab62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6192914
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1411064}
1 file changed
tree: e46c85acf268064eb1e46c016f0d3f60d29040e2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. description
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.