Google Git
Sign in
chromium / chromium / src / b5cf78689c8fe54ff26b3d89ee38b85d106711b1
commitb5cf78689c8fe54ff26b3d89ee38b85d106711b1[log] [tgz]
authorNicolás Peña <npm@chromium.org>Thu Apr 10 19:51:38 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Apr 10 19:51:38 2025
treebe5438d2866b992475f6d6513c45cead90c21654
parent009845af5b9c79f1a5d4d0d74448db5dafb01e00 [diff]
[FedCM] Add a delegate to disable half height during TalkBack

Currently, TalkBack has an issue where the accounts are not properly
iterated over when there are a certain number of accounts because the
RecyclerView thinks its fully visible but the container clips it, and
somehow the a11y tree knows the number of items but is unable to reach
the ones past the clipped portion. To solve this problem, we introduce
a delegate which disables half height when an a11y focus event occurs
in the content of the sheet. This could be applied to button mode as
well, but due to the large initial size, it doesn't seem possible to
trigger this issue in button mode using a small number of accounts, so
the change is kept minimal in scope.

The delegate could also attempt to restore half height if focus is
lost, but this could introduce an issue because the bottomsheet requests
focus when it is rendered. Also, this is a strange enough case that it
is not worth the additional complexity.

Demo can be found in the linked issue.

Fixed: 409132558
Change-Id: Ie725df0d11e846bface7096227655a2ae06ad363
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6446800
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: Zachary Tan <tanzachary@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1445450}
4 files changed
tree: be5438d2866b992475f6d6513c45cead90c21654
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.