Google Git
Sign in
chromium / chromium / src / b5d3afadb502337b5710cf0be95d3befa003d6a9
commitb5d3afadb502337b5710cf0be95d3befa003d6a9[log] [tgz]
authorBartek Nowierski <bartekn@chromium.org>Fri Nov 19 22:47:29 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Nov 19 22:47:29 2021
tree1a56dc9f4aecdef97dd4c92e2bf4a34a16f0b531
parent9f9bf56f452ae488d67d10f3370768382e2faa54 [diff]
Move raw_ptr support check from StorageTraits to UnretainedWrapper

In the current code, UnretainedWrapper::ptr_ would be unconditionally
rewritten from T* to raw_ptr<T> during Big Rewrite. This would break if
T isn't supported by raw_ptr<>. Compatibility check in StorageTraits was
supposed to counteract that, but it wouldn't catch direct calls to
base::Unretained(). Better to move the check to UnretainedWrapper, where
it will handle all cases, by defining RawPtrTraits.

The rewriter won't touch T* in RawPtrTraits, because it's part of the
`using` clause.

It is ok to have raw_ptr<T> in the current codebase, because without
use_backup_ref_ptr=true it uses NoOpImpl, thus incurring no cost.

Bug: 1237534, 1080832
Change-Id: I31991c3455c92e3358aa26924b70515fb99417de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3290780
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Bartek Nowierski <bartekn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#943703}
1 file changed
tree: 1a56dc9f4aecdef97dd4c92e2bf4a34a16f0b531
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.