Google Git
Sign in
chromium / chromium / src / b5e3ed542d7f7c43ffd6a692b8e385134ebc014c
commitb5e3ed542d7f7c43ffd6a692b8e385134ebc014c[log] [tgz]
authorCaroline Rising <corising@chromium.org>Sat Feb 12 01:42:57 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Sat Feb 12 01:42:57 2022
tree487a998098c70be754da91ad091a5011251018ca
parent8268950960ec147fed2668bd2a17cfab347ac972 [diff]
Unified side panel: move global registry out of coordinator and create new ComboboxModel

This cl:
- Moves existing global SidePanelRegistry out of the
SidePanelCoordinator and into BrowserView.
- Creates new SidePanelRegistryObserver class.
- Creates new SidePanelComboboxModel class which can hold entry ids and
icons.
- Lets the SidePanelCoordinator observe the global SidePanelRegistry
and updates the SidePanelComboboxModel according to registry changes.

Bug: 1287237
Change-Id: I1ea25409fc5b48fcb76f9ecfaabf3d1afc8be1f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3445443
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/main@{#970268}
12 files changed
tree: 487a998098c70be754da91ad091a5011251018ca
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.