| commit | b5fb37315339f14b253b09264ae99c9eb8d4e049 | [log] [tgz] |
|---|---|---|
| author | Andrew Paseltiner <apaseltiner@chromium.org> | Mon Sep 16 14:28:43 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Sep 16 14:28:43 2024 |
| tree | 1b421ca208216ec164f91651e3af434e09cda215 | |
| parent | 3b41bd925cf445c78ef8e508dcce099d73c5921f [diff] |
Prevent multiplication overflow in ComputeChannelCapacityScopes Previously, the multiplication here was done using 32-bit integer arithmetic, which could overflow, before being summed, correctly, into a double. We instead perform double multiplication to prevent the overflow. Without this change, a source can evade the privacy check corresponding to the max channel capacity for a source using scopes. Bug: 366998247 Change-Id: I767896a5b8a14b3834c6bd5814659d667f9b012c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5866189 Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Cr-Commit-Position: refs/heads/main@{#1355834}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.