commit b5fba5e54dcb5adeb750844312e58f8b21b40f7f
author Kenichi Ishibashi <bashi@chromium.org> Mon Sep 09 07:53:52 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Sep 09 07:53:52 2024
tree 9ca49d1bca19a39280c27f4872dc878894cda322
parent d47b1ef74e2cb89c3a1254d0be0d94b1b66afb8e

Call HttpStreamPool::Job::Delegate methods always asynchronously

HttpStreamFactory::Job always call delegate methods asynchronously
(see crrev.com/2827533002 for the reason). When we call delegate
methods synchronously from the HEv3 code path, HttpNetworkTransaction
changes its behavior slightly.

For example, suppose the connection is negotiated to use HTTP/2 and
the server immediately sends GOAWAY. In this case,
HttpNetworkTransaction receives an HttpStream via
HttpStreamRequest::Delegate::OnStreamReady() and tries to initialize
it via InitializeStream(). When a Job calls OnStreamReady()
asynchronously, InitializeStream() fails since the underlying
SpdySession performed a task that handled GOAWAY. When a Job calls
OnStreamReady() synchronously, InitializeStream() succeeds since the
task that handles GOAWAY has scheduled but is not yet executed.
This results in having a different errors in HttpNetworkTransaction.
Several tests depends on this behavior and fail due to the different
behavior.

Make HttpStreamPool::JobDelegate method calls always asynchronously
to fix the problem.

Bug: 346835898
Change-Id: Iaa99c34b1e7a40262a42b6c3a7b55a6b8aa2bf94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5837329
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1352584}