Google Git
Sign in
chromium / chromium / src / b60d1531d0d62d10c87f7a77a256643b4cc8df6c
commitb60d1531d0d62d10c87f7a77a256643b4cc8df6c[log] [tgz]
authorQuentin Pubert <qpubert@google.com>Fri Apr 05 14:39:28 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Apr 05 14:39:28 2024
treea359fb3557d2d337b77aab7eeffc6346122b6401
parentca0b40472d41ba2fbdc2a26d2665ba24552084a5 [diff]
[iOS] Update TabGroupItem to handle removed TabGroup

This CL updates TabGroupItem to handle a situation where the underlying
TabGroup instance has been removed from the WebStateList. Ideally,
TabGroupItem instances should be removed as soon as the underlying group
is deleted but it appears not to always be possible e.g. removing a
TabGroupItem by applying a snapshot that does not contain this item may
trigger callbacks by the UICollectionView in TabStripViewController
which need to read from the data source while the snapshot is being
applied, at which point it is not clear whether the TabGroupItem that is
meant to be removed will be returned by the data source or not.

Change-Id: I91a2178192e7891ab6279a4f762fd4e5cc0bbbc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5419237
Auto-Submit: Quentin Pubert <qpubert@google.com>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Louis Romero <lpromero@google.com>
Cr-Commit-Position: refs/heads/main@{#1283123}
3 files changed
tree: a359fb3557d2d337b77aab7eeffc6346122b6401
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.