Add methods to CanonicalCookie to serialize/deserialize partition keys
to/from strings.

The serialization scheme for a cookie partition key
(absl::optional<net::SchemefulSite) is as follows:

- If the key is absl::nullopt, the output is net::kEmptyPartitionKey
- If the key contains a file origin, the output is
  SchemefulSite::SerializeFileSiteWithHost().
- Otherwise the output is SchemefulSite::Serialize().

The serialization method returns false if the partition key is invalid
or the SchemefulSite's origin is opaque. If this method returns false
the cookie should not be saved to disk.

The deserialization scheme works as follows:
- If the input is net::kEmptyPartitionKey, the output is absl::nullopt
- Otherwise return SchemefulSite::Deserialize(input)

The deserialization method returns false if the serialized key is
invalid. If this method returns false the cookie should not be loaded
from disk into a CanonicalCookie and should be deleted.

This CL also adds the method SerializeFile[Origin|Site]WithHost
to url::Origin and net::SchemefulSite respectively. Unlike Serialize,
this method should only be called on file origins and preserves the
origins' host.

Bug: 1225444
Change-Id: Ic113b693dfc450857a43cbf2ca645a5adf6b016e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3032294
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/master@{#905372}
7 files changed
tree: dbd517504c20d4e46e23064480af0b969847cc95
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.