Google Git
Sign in
chromium / chromium / src / b6553d262c79312ae8a052dceda3713144233171
commitb6553d262c79312ae8a052dceda3713144233171[log] [tgz]
authorMarc Treib <treib@chromium.org>Thu Dec 13 16:04:06 2018
committerCommit Bot <commit-bot@chromium.org>Thu Dec 13 16:04:06 2018
tree97b480078012e1bebbecc8ad29f40dbe20cdee1d
parentde25089653d652a4963030c9a98b0a022813b399 [diff]
Prefer using SyncService (the interface) over ProfileSyncService (the impl)

It's better to use the interface rather than the concrete implementation.
For one, this will make testing easier.

This CL trivially switches a bunch of uses of ProfileSyncService over to
SyncService. There are still many left.

Bug: 910518
Change-Id: I6890db739b3333c056c6b6631d2074a8fd3f2efe
Reviewed-on: https://chromium-review.googlesource.com/c/1375718
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616325}
17 files changed
tree: 97b480078012e1bebbecc8ad29f40dbe20cdee1d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .