commit b66e239b94e60ee70eb5b93da30e2468d5b4e968
author Theresa Sullivan <twellington@chromium.org> Thu Jun 16 19:24:34 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Jun 16 19:24:34 2022
tree fe56e5505138a3a0ebf5a82a8e2858355b0e7fd5
parent dfd84d6c040d64dd5fa8906ad6e82befaf18281b

👩‍🔧 Add on-device unit test target for signin

Add a new unit_device_javatests target for
//chrome/browser/ui/android/signin and move qualifyign tests.

Bug: 1331970, 1331965, 1331967, 1331971, 1331968, 1331969
Change-Id: I622e8d7e19c4efab44e4252c42cfbb252baf0a0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3708715
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa Sullivan <twellington@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1015027}

chrome/android/BUILD.gn

diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
index 9dc6ece..9b5875a 100644
--- a/chrome/android/BUILD.gn
+++ b/chrome/android/BUILD.gn
@@ -3165,6 +3165,7 @@
     "//chrome/browser/optimization_guide/android:unit_device_javatests",
     "//chrome/browser/partnercustomizations:unit_device_javatests",
     "//chrome/browser/ui/android/appmenu/internal:unit_device_javatests",
+    "//chrome/browser/ui/android/signin:unit_device_javatests",
     "//chrome/browser/ui/messages/android:unit_device_javatests",
     "//chrome/browser/user_education:unit_device_javatests",
     "//chrome/browser/video_tutorials/internal:unit_device_javatests",

chrome/browser/ui/android/signin/BUILD.gn

diff --git a/chrome/browser/ui/android/signin/BUILD.gn b/chrome/browser/ui/android/signin/BUILD.gn
index f898529..9f32b9ae8 100644
--- a/chrome/browser/ui/android/signin/BUILD.gn
+++ b/chrome/browser/ui/android/signin/BUILD.gn
@@ -175,17 +175,8 @@
 android_library("javatests") {
   testonly = true
   sources = [
-    "java/src/org/chromium/chrome/browser/ui/signin/ConfirmImportSyncDataDialogTest.java",
-    "java/src/org/chromium/chrome/browser/ui/signin/ConfirmManagedSyncDataDialogTest.java",
-    "java/src/org/chromium/chrome/browser/ui/signin/ConfirmSyncDataIntegrationTest.java",
-    "java/src/org/chromium/chrome/browser/ui/signin/ConfirmSyncDataStateMachineDelegateTest.java",
-    "java/src/org/chromium/chrome/browser/ui/signin/SignOutDialogRenderTest.java",
-    "java/src/org/chromium/chrome/browser/ui/signin/SignOutDialogTest.java",
-    "java/src/org/chromium/chrome/browser/ui/signin/SigninPromoControllerRenderTest.java",
     "java/src/org/chromium/chrome/browser/ui/signin/account_picker/AccountPickerBottomSheetRenderTest.java",
     "java/src/org/chromium/chrome/browser/ui/signin/account_picker/AccountPickerBottomSheetTest.java",
-    "java/src/org/chromium/chrome/browser/ui/signin/account_picker/AccountPickerDialogTest.java",
-    "java/src/org/chromium/chrome/browser/ui/signin/fre/FreUMADialogTest.java",
   ]
   deps = [
     ":java",
@@ -194,11 +185,48 @@
     "//chrome/android:chrome_java",
     "//chrome/browser/flags:java",
     "//chrome/browser/preferences:java",
-    "//chrome/browser/profiles/android:java",
     "//chrome/browser/signin/services/android:java",
     "//chrome/browser/ui/android/night_mode:night_mode_java_test_support",
     "//chrome/test/android:chrome_java_integration_test_support",
     "//components/browser_ui/bottomsheet/android:java",
+    "//components/signin/core/browser:signin_enums_java",
+    "//components/signin/public/android:java",
+    "//components/signin/public/android:signin_java_test_support",
+    "//content/public/test/android:content_java_test_support",
+    "//third_party/android_deps:espresso_java",
+    "//third_party/android_support_test_runner:runner_java",
+    "//third_party/androidx:androidx_annotation_annotation_java",
+    "//third_party/androidx:androidx_test_runner_java",
+    "//third_party/hamcrest:hamcrest_java",
+    "//third_party/junit",
+    "//third_party/mockito:mockito_java",
+    "//ui/android:ui_java_test_support",
+  ]
+}
+
+android_library("unit_device_javatests") {
+  testonly = true
+  sources = [
+    "java/src/org/chromium/chrome/browser/ui/signin/ConfirmImportSyncDataDialogTest.java",
+    "java/src/org/chromium/chrome/browser/ui/signin/ConfirmManagedSyncDataDialogTest.java",
+    "java/src/org/chromium/chrome/browser/ui/signin/ConfirmSyncDataIntegrationTest.java",
+    "java/src/org/chromium/chrome/browser/ui/signin/ConfirmSyncDataStateMachineDelegateTest.java",
+    "java/src/org/chromium/chrome/browser/ui/signin/SignOutDialogRenderTest.java",
+    "java/src/org/chromium/chrome/browser/ui/signin/SignOutDialogTest.java",
+    "java/src/org/chromium/chrome/browser/ui/signin/SigninPromoControllerRenderTest.java",
+    "java/src/org/chromium/chrome/browser/ui/signin/account_picker/AccountPickerDialogTest.java",
+    "java/src/org/chromium/chrome/browser/ui/signin/fre/FreUMADialogTest.java",
+  ]
+  deps = [
+    ":java",
+    "//base:base_java",
+    "//base:base_java_test_support",
+    "//chrome/browser/flags:java",
+    "//chrome/browser/preferences:java",
+    "//chrome/browser/profiles/android:java",
+    "//chrome/browser/signin/services/android:java",
+    "//chrome/browser/ui/android/night_mode:night_mode_java_test_support",
+    "//chrome/test/android:chrome_java_integration_test_support",
     "//components/browser_ui/modaldialog/android:java",
     "//components/externalauth/android:java",
     "//components/prefs/android:java",