Google Git
Sign in
chromium / chromium / src / b6b4c12871693734354f7a9731c145ead2fa8d47
commitb6b4c12871693734354f7a9731c145ead2fa8d47[log] [tgz]
authorWill Cassella <cassew@chromium.org>Tue Jun 21 18:13:41 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jun 21 18:13:41 2022
tree2e45cf625465d93301381194fdeb132464781c6b
parent94665b6ede3cd36d9a87c2ffd1a84f452d5ca805 [diff]
HLS: Limit target duration to base::TimeDelta::FiniteMax() / 10

This CL sets a limit on the max value of the playlist's segment target
duration to avoid potential sources of overflow. FiniteMax()/10 was
chosen because it leaves plenty of headroom for situations where this
value may be multiplied (when validating the EXT-X-SERVER-CONTROL tag
for example), while still being quite large. In addition, this CL places
a restriction on the value of the playlist's partial segment target
duration, in that it may not exceeds the playlist's segment target
duration. This CL includes tests for both restrictions.

Bug: 1266991
Change-Id: Ie01498be38a4d22b1e501c69ad2681a7288e6a95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3712368
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Commit-Queue: Will Cassella <cassew@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1016311}
5 files changed
tree: 2e45cf625465d93301381194fdeb132464781c6b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_web/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.