commit | b6dfebfcd597a20620eb5a5de9ff5fa266836fde | [log] [tgz] |
---|---|---|
author | Findit <findit-for-me@appspot.gserviceaccount.com> | Tue Mar 12 11:20:42 2019 |
committer | Findit <findit-for-me@appspot.gserviceaccount.com> | Tue Mar 12 11:20:42 2019 |
tree | 633d7a5c4081213319ee9fa08cedd0226ab71680 | |
parent | 9499addc19a0ad37979f885d1fe3c0eeb7765af0 [diff] |
Revert "Update PWA frame color to match HTML theme-color meta tag" This reverts commit ea67b57d05efdf10e6aadae6776cc0f428d0991a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 639842 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZWE2N2I1N2QwNWVmZGYxMGU2YWFkYWU2Nzc2Y2MwZjQyOGQwOTkxYQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests%20%28dbg%29/9916 Sample Failed Step: browser_tests on (none) GPU on Mac Sample Flaky Test: BrowserNonClientFrameViewBrowserTest.HTMLMetaThemeColorOverridesManifest Original change's description: > Update PWA frame color to match HTML theme-color meta tag > > This CL updates PWA windows to use the HTML theme-color meta tag > as the frame color over the manifest's theme_color. > > This is in line with the Web App Manifest spec text: > https://www.w3.org/TR/appmanifest/#theme_color-member > > Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=382160&signed_aid=n5SryIX1Gm4-apNPrIOfzA==&inline=1 > After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=382161&signed_aid=o5hmc8fm-i1d6FXwuam15A==&inline=1 > > Bug: 872121 > Change-Id: Ib431f7b7612c5167cde2489f0263240747d8d50d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496267 > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Camille Lamy <clamy@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Auto-Submit: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#639842} Change-Id: I534ff44a84967d528ecd5b8b6f24622d9fb51ea7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 872121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517793 Cr-Commit-Position: refs/heads/master@{#639878}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .