Google Git
Sign in
chromium / chromium / src / b6e9ac57b40e9d4706a072f901bafd8ed8e6b8b7
commitb6e9ac57b40e9d4706a072f901bafd8ed8e6b8b7[log] [tgz]
authorDevlin Cronin <rdevlin.cronin@chromium.org>Wed Jan 04 22:49:36 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jan 04 22:49:36 2023
treeed7a03320039e5311baaec9e1cc844df629b419b
parent419e4eb15ae1dc4d2cba1770ec11788a0b8340a7 [diff]
[Extensions] Adjust ExtensionFunctionHistogramValueTest

We have a test that verifies the extension function histogram value
is updated in enums.xml when it changes in the source .h file. This
test looks for the presence of "ENTRY = <val>" in the source file, but
this means that any string that ends with `ENTRY` will pass (e.g.,
the test won't error if the enums.xml entry is `FOO` and the source
file entry is `DELETED_FOO`). Update the test to look for
` ENTRY = <val>` instead, so that deletions in the source file need
to be reflected in the enums.xml file.

Bug: None
Change-Id: I5519e725f7c059f81374e97a2c16a70f1177bb32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4134784
Auto-Submit: Devlin Cronin <rdevlin.cronin@chromium.org>
Reviewed-by: Tim <tjudkins@chromium.org>
Commit-Queue: Devlin Cronin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1088994}
1 file changed
tree: ed7a03320039e5311baaec9e1cc844df629b419b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.