Google Git
Sign in
chromium / chromium / src / 242098c21dc6953d75c938b37a85cee51f6db614
commit242098c21dc6953d75c938b37a85cee51f6db614[log] [tgz]
authorMichael Giuffrida <michaelpg@chromium.org>Sat Mar 10 01:12:45 2018
committerCommit Bot <commit-bot@chromium.org>Sat Mar 10 01:12:45 2018
treeca9b99e5beabcd08cb71266abddc360356fa4682
parentcbbf6d7ba09944355e52c1cad494d8963398dc62 [diff]
ShellExtensionLoaderTest should use existing PrefService

ShellExtensionLoaderTest associates a new TestingPrefServiceSimple with
the BrowserContext, but instead should associate the existing
PrefService created by ExtensionsTest.

Creating its own TestingPrefServiceSimple, besides being unnecessary,
leads to invalid casts of its PrefRegistrySimple to a
PrefRegistrySyncable (breaking the Linux CFI bots).

TBR=rdevlin.cronin@chromium.org

Bug: 820647
Change-Id: I2ae62a396622d034c8c5b04bbe9dabb529b5bd25
Reviewed-on: https://chromium-review.googlesource.com/957871
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542302}
1 file changed
tree: ca9b99e5beabcd08cb71266abddc360356fa4682
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_cleaner/
  11. chrome_elf/
  12. chromecast/
  13. chromeos/
  14. cloud_print/
  15. components/
  16. content/
  17. courgette/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. notification_helper/
  38. pdf/
  39. ppapi/
  40. printing/
  41. remoting/
  42. rlz/
  43. sandbox/
  44. services/
  45. skia/
  46. sql/
  47. storage/
  48. styleguide/
  49. testing/
  50. third_party/
  51. tools/
  52. ui/
  53. url/
  54. .clang-format
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. AUTHORS
  62. BUILD.gn
  63. CODE_OF_CONDUCT.md
  64. codereview.settings
  65. DEPS
  66. ENG_REVIEW_OWNERS
  67. LICENSE
  68. LICENSE.chromium_os
  69. OWNERS
  70. PRESUBMIT.py
  71. PRESUBMIT_test.py
  72. PRESUBMIT_test_mocks.py
  73. README.md
  74. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .