Clean up error handling in declarative shadow DOM code This CL started as an implementation of exception throwing from the parsing code for DSD. However, as discussed in the issue: https://github.com/whatwg/html/issues/10527 the desire is not to add such exceptions, mostly for fear of opening new XSS endpoints. So that bit has been ripped out of the CL, and what's left is a bit of a cleanup that at least moves all errors (including wrong-mode-string) to a central place in `ErrorMessageForAttachShadow`. This also allowed me to remove the `DeclarativeShadowRootMode` enum and some related code. I also added a few small explicit tests that exceptions are not thrown/fired during HTML parsing. Since the spec says exceptions should be fired in this case, I will put up a spec PR soon. For now, though, this is not a behavioral change for Chrome, so no need to do an I2S or anything. The spec, currently: -https://html.spec.whatwg.org/#parsing-main-inhead Start at `A start tag whose tag name is "template"`, then Otherwise, and then point 8, which is: > Attach a shadow root with declarative shadow host element, mode, > clonable, serializable, delegatesFocus, and "named". If an exception > is thrown, then catch it, report it for declarative shadow host > element's relevant global object, insert an element at the adjusted > insertion location with template, and return. Change-Id: I0a8e2c8fa1301efdd28f9bb786f9ca8d3596c2fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5750587 Auto-Submit: Mason Freed <masonf@chromium.org> Commit-Queue: Di Zhang <dizhangg@chromium.org> Reviewed-by: Di Zhang <dizhangg@chromium.org> Cr-Commit-Position: refs/heads/main@{#1339961}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.