Google Git
Sign in
chromium / chromium / src / b72401613d9f46aefe39ef0770fed1a601657569
commitb72401613d9f46aefe39ef0770fed1a601657569[log] [tgz]
authorQuentin Pubert <qpubert@google.com>Mon May 06 10:24:41 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon May 06 10:24:41 2024
treee03683bf267edc49b35869524c0b879d1a8726c8
parent97a239811b2e2f60d1a7f0b0cde1eeb53afed103 [diff]
[iOS][TabStrip] Use data source to identify selected cell in layout

This CL adds a `selectedItem: TabSwitcherItem?` field to TabStripLayout,
which can be used to identify the selected item in the data source when
trying to determine the selected IndexPath of the collection view. This
method yields better results i.e. avoids unnecessary/glitchy looking
layout invalidations when the number of cells changes in the collection
view e.g. while collapsing/expanding groups or closing tabs.

Demo:
https://drive.google.com/file/d/10ep_DsrVheLBkxqWIvQw5mrvPupd0p9c/view

(cherry picked from commit 329d25bbf9e3b846fb498be8572005f3997ec18c)

Change-Id: I51add7d945b055afa2c555a35f500fc529af37d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5458561
Reviewed-by: Ewann Pellé <ewannpv@chromium.org>
Commit-Queue: Quentin Pubert <qpubert@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1290793}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5513739
Reviewed-by: Ameur Hosni <ameurhosni@google.com>
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Cr-Commit-Position: refs/branch-heads/6422@{#705}
Cr-Branched-From: 9012208d0ce02e0cf0adb9b62558627c356f3278-refs/heads/main@{#1287751}
2 files changed
tree: e03683bf267edc49b35869524c0b879d1a8726c8
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.