commit b76bc7234b181fd6ddc8cafe90a32453d9a689c0
author Alex Chen <alexwchen@chromium.org> Wed Apr 09 18:11:01 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Apr 09 18:11:01 2025
tree 32068639455f315540f6c3175b42c1e72a9e1136
parent bbe1a9db7bd975370f1d6fb38454ef3de090e5dd

Reland "[omnibox] Clear shortcuts with deleted/inactive keywords"

This is a reland of commit 56516be43412f3998e73e56694cbe2818a7fe9d6

Original change was reverted due to lifetime issue (UaF) for `template_url_service_observation_`. Patch calls `template_url_service_observation_.Reset()` to stop the ongoing observation before the `template_url_service_observation_` is destroyed.

Original change's description:
> [omnibox] Clear shortcuts with deleted/inactive keywords
>
> Currently, when a search engine is deleted/inactive, any shortcuts from
> the search engine will still show as shortcut suggestions. As a result,
> formatting of those suggestions are not formatted properly since the
> keyword of the suggestions does not exist in the TemplateURLService. For
> example, if a search was made in scoped mode, the unscoped result after
> engine deletion may show "keyword foo query".
>
> For inactive search engines, a user would not expect shortcuts to
> keywords while they're deactivated.
>
> This change adds an observer to the ShortcutsBackend to check for
> deleted/inactive keywords whenever the TemplateURLService is updated.
> This will ensure shortcut suggestions with keywords that have been deleted
> or inactive are removed.
>
> A future improvement could include suppressing corresponding history
> provider suggestions as well.
>
> Before: https://screenshot.googleplex.com/4GikJdoAz5MhVUn
> After: https://screenshot.googleplex.com/KZGWQjwYTTTk8qH
>
> Bug: 406761194
> Change-Id: I36bf0e3b18dd1ad60d3356db38e807be34fdbc3a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6416724
> Commit-Queue: Alex Chen <alexwchen@chromium.org>
> Reviewed-by: manuk hovanesian <manukh@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1444371}

Include-Ci-Only-Tests: chromium.memory:Linux ASan LSan Tests (1)|browser_tests
Bug: 406761194
Change-Id: I379c91b00bc7a33972818d2305ea20090079b3fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6438704
Commit-Queue: Alex Chen <alexwchen@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1444850}