Google Git
Sign in
chromium / chromium / src / b7878a796fab1364653aba0681166901aa100f04
commitb7878a796fab1364653aba0681166901aa100f04[log] [tgz]
authorAaron Krajeski <aaronhk@chromium.org>Thu Mar 16 16:17:04 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Mar 16 16:17:04 2023
treec8a4bf77551f401d4827509c426e5bdf5fdf3ffc
parent4d813ee5714ec744aa19eb13252d4fb747f27420 [diff]
Make color hint interpolation match the gradient

Color hints were previously being generated by a Blend() function that
produced sRGBLegacy colors, no matter what gradient interpolation was
set. This CL changes gradient hints to use the new
Color::InterpolateColors function that can handle different color
spaces. graphics/color_blend.h is no longer used and deleted.

In the spec, when no interpolation space is specified, "legacy" colors
are interpolated in the sRGB color space while non-legacy colors are
interpolated in OKLAB. In order to support this a "kSRGBLegacy" color
interpolation space is added to Color::ColorInterpolation space to
match the Color::ColorSpace of the same name. This space interpolates
exactly the same way as "kSRGB", but produces a legacy color for
supporting legacy interpolation between points.

Also, Color::ColorSpace::kRGBLegacy is renamed to kSRGBLegacy to match
convention elsewhere (it is in the "sRGB" color space, after all).

Some gradient expectations are rebaselined to match the results of using
higher resolution colors to generate them.

Bug: 1416273, 1411351
Change-Id: I24446988e981291c6b0c24ea3b5d8afd39aaceca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4250939
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118133}
43 files changed
tree: c8a4bf77551f401d4827509c426e5bdf5fdf3ffc
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.