[views-ax] Fix Tooltip Text in `TRENDING SEARCHES` in omnibox.

The CL:6089787 introduces a regression where the tooltip text of the
`TRENDING SEARCHES` toggle button is incorrectly displayed when it
is hidden.
When the trending search results are hidden, the tooltip text
should be `Show Suggestions`, but instead, it shows
`Hide Suggestions`.

The primary goal of `CL:6089787` was to migrate tooltip text to the
new push mechanism, which it successfully achieves. However, an
issue arises when the button is toggled,
as the function `OmniboxHeaderView::UpdateUI()` is called
when the button is hovered over and then unhovered.
This function explicitly sets the TooltipText value using
`SetTooltipText()`. The main problem is that it always sets the
tooltip text to `Hide Suggestions`, even when the popup is hidden.
This discrepancy did not occur with the previous pull-based
mechanism but is now evident with the push-based mechanism.

To resolve this, the `UpdateTooltipText()` function of the toggle
button class is explicitly called within the
`OmniboxHeaderView::UpdateUI()` function. This ensures that the
correct tooltip text is displayed based on the toggle state
(i.e., whether the popup is open or not).

Fixed: 406455724
Change-Id: I243a5230fada3b4e86400ed2f00656b8a0aebb7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6424522
Commit-Queue: Divyansh Mangal <dmangal@microsoft.com>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1442587}
2 files changed
tree: b86d4b3e3e3efcd6027d6c5ee4445308e222283e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .git-blame-ignore-revs
  53. .gitallowed
  54. .gitattributes
  55. .gitignore
  56. .gitmodules
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. CPPLINT.cfg
  68. CRYPTO_OWNERS
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.