Google Git
Sign in
chromium / chromium / src / b7a8391574e49f9212f63f1cec6dd846c035f7b2
commitb7a8391574e49f9212f63f1cec6dd846c035f7b2[log] [tgz]
authorWez <wez@chromium.org>Sat Feb 23 04:01:21 2019
committerCommit Bot <commit-bot@chromium.org>Sat Feb 23 04:01:21 2019
treeac7277d40eb99e04675175dff71247054f5f359e
parent4ce646577a0d7e30abb729aac6f7fce3d2dba136 [diff]
Switch ScopedTaskEnvironment's Run() timeout to use ADD_FAILURE.

ScopedTaskEnvironment would previously LOG(FATAL) on Run() timeout,
causing the calling process to crash, preventing tests scheduled later
in the same batch from being run.

ScopedTaskEnvironment now uses MakeExpectedNotRunClosure() as the Run()
timeout callback, allowing test batches to run to completion.

Bug: 918724
Change-Id: I23269ee9d9e2c55108a57d4081f62a7769b1f44b
Reviewed-on: https://chromium-review.googlesource.com/c/1481655
Commit-Queue: Wez <wez@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634938}
2 files changed
tree: ac7277d40eb99e04675175dff71247054f5f359e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .