commit | b7aab6184efe27f8fb5a1f961f64a35ae08c2dd1 | [log] [tgz] |
---|---|---|
author | Rahul Singh <rahsin@microsoft.com> | Fri Nov 08 23:05:52 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Nov 08 23:05:52 2024 |
tree | e96ea203b464423d04ba19d4d8cf3548726c31bf | |
parent | 244c632fde6658a068b3209e9bd73f4d3c854b91 [diff] |
FSO: Destroy file observation in Local FS when parent disappears This change updates FileSystemAccessLocalPathWatcher to watch the parent directory for file observations. Then in the OnChanges() callback method, when the current scope's watch type is kFile, we update the `change_info` to align with a file watch vs. a directory watch. This change also fixes an issue associated with directly watching a file where calling close() on a writeable would result in an additional `appeared` event as the crswap file overwrote the contents of the file. Now that we are watching the parent directory, this correctly shows up as a single `modified` event. Bug: 350791549, 340584120, 353547877 Change-Id: I888f88470a259f4baba8c6e225b62c148ab37303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5941144 Reviewed-by: Daseul Lee <dslee@chromium.org> Commit-Queue: Rahul Singh <rahsin@microsoft.com> Reviewed-by: Nathan Memmott <memmott@chromium.org> Cr-Commit-Position: refs/heads/main@{#1380676}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.