commit | b80dded50e658266e4d718a00fd147e1212dbd45 | [log] [tgz] |
---|---|---|
author | Marc Treib <treib@chromium.org> | Thu Dec 13 09:54:06 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Dec 13 09:54:06 2018 |
tree | 09ac88d244ab10910b9ef3183e61ec03d1d2852f | |
parent | dc58211d9a15261962cd164c53e3acd6fc186350 [diff] |
Simplify SyncStartupTracker: don't use Profile (just SyncService) Previously, SyncStartupTracker checked Profile::IsSyncAllowed before getting a SyncService from the factory, presumably to avoid creating it in case it doesn't exist yet. However, in all places where it's constructed, we do already have a SyncService around. So this CL changes SyncStartupTracker to just take a SyncService. This generally makes things simpler, and it'll ease testing since we can now use TestSyncService instead of ProfileSyncServiceMock (and don't have to go through the factory, but can instead just inject the dependency directly). Bug: 910518 Change-Id: Iae3d92f7605d42b97d51dcff3afc9dcc29666cad Reviewed-on: https://chromium-review.googlesource.com/c/1367654 Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#616254}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .