Google Git
Sign in
chromium / chromium / src / b81edbf02a6ab821e51ba5128b3984fc2e8653c2
commitb81edbf02a6ab821e51ba5128b3984fc2e8653c2[log] [tgz]
authorRebekah Potter <rbpotter@chromium.org>Wed Jun 22 00:39:37 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jun 22 00:39:37 2022
tree4b658d7ed20d7a79da11da558bf175b6f1061dc0
parent5e676bfdc8c9329ee5f749098383586c7ad87bde [diff]
[M102] Print Preview: Fix missing destinations in dialog

Print Preview's dialog fails to display destinations in cases where all
printers have already been loaded into the backing destination store
before the dialog is opened. This can happen if users have all printer
types represented in their recent printers + system default printer, as
such printers are pre-loaded at startup to populate the dropdown. Note
the system default printer is a local/native printer.

This bug previously did not manifest because users did not have an
extension, privet, and cloud printer all in their recent destinations.
However, with the removal of privet and cloud printer types, this bug
could be triggered by simply having a recent extension printer + having
a system default native printer.

(cherry picked from commit 76e2dc10bc759469dcaea1604a582fd2c6bd55fa)

Bug: 1330678
Change-Id: Ia0684b908690cca6691c9d44ad94296dadfb9536
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3696838
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1012174}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3698743
Cr-Commit-Position: refs/branch-heads/5005@{#1190}
Cr-Branched-From: 5b4d9450fee01f821b6400e947b3839727643a71-refs/heads/main@{#992738}
2 files changed
tree: 4b658d7ed20d7a79da11da558bf175b6f1061dc0
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.