Google Git
Sign in
chromium / chromium / src / 2a2a447bc9f80105c7d1eb42a4e032660264cf0d
commit2a2a447bc9f80105c7d1eb42a4e032660264cf0d[log] [tgz]
authorDaniel Andersson <dandersson@chromium.org>Fri Sep 16 23:43:35 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Sep 16 23:43:35 2022
tree4a0c25c2c3a9bc3dba2beeb60de1b0ca716296f6
parentda0e8cdfc0b5117afa98e4122e4c8458bb288084 [diff]
saved_desks: Unify some functionality in SavedDesk{Grid,Library}View.

This is a refactoring that changes how the saved desk grid is
initialized. We had two functions (`AddOrUpdateTemplates` and
`PopulateGridUI`) that did very similar things. The latter has now been
removed.

`AddOrUpdateTemplates` is now known as `AddOrUpdateEntries`, ditto for
`DeleteTemplates`.

Parameters were renamed to be more indicative of what they do, rather
than how they are currently used.

Additionally, SavedDeskPresenter's constructor will no longer do
`GetAllEntries`. The result of that call was never used since it
happened before the overview grid had been created.

Bug: 1363382
Change-Id: I87f6238f2a2c778e0a5e5394929d2f67b54316ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3894971
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Yongshun Liu <yongshun@chromium.org>
Commit-Queue: Daniel Andersson <dandersson@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1048296}
7 files changed
tree: 4a0c25c2c3a9bc3dba2beeb60de1b0ca716296f6
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.