Google Git
Sign in
chromium / chromium / src / b8e0ac731a4921f973bebe02ffac362974c86c34
commitb8e0ac731a4921f973bebe02ffac362974c86c34[log] [tgz]
authorDan Clark <daniec@microsoft.com>Tue Apr 23 03:28:58 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Apr 23 03:28:58 2024
treedb8fc95a7106a8c4b7abc9d4edd7aa058e11b1f0
parent7abb5431e0b273e0409576a46893a2bd04589445 [diff]
Pass visited set through in SlowGetValueForControlIncludingContentEditable

The CL [1] attempted to fix a stack overflow issue from recursive
accessible name references by ensuring that the visited set
was passed all the way through from AXNodeObject::GetValueContributionToName to a possibly recursive
operation in SlowGetValueForControlIncludingContentEditable.

However, I failed to actually pass the visited set through all the
way.

This should have been caught by the test coverage I thought I added,
but apparently I must have broken that trying to simplify it, and
it no longer catches the stack overflow condition.

So, here I'm ensuring that the visited set is actually passed through,
modifying (and triple-checking) the original test so it actually
catches the crash, and adding the alternative repro suggested in [2].

[1] https://chromium-review.googlesource.com/c/chromium/src/+/5388968
[2] https://issues.chromium.org/u/1/issues/335553723#comment3

Bug: 330720260, 335553723
Change-Id: I7c9bdc64653a45184a7a0aaa6fd8af90f347497f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5468155
Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Commit-Queue: Dan Clark <daniec@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1291056}
2 files changed
tree: db8fc95a7106a8c4b7abc9d4edd7aa058e11b1f0
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.