commit b8e0b24449b46049ec74aef53fdeb537e5ab6211
author Lukasz Anforowicz <lukasza@chromium.org> Tue Feb 20 18:01:37 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Feb 20 18:01:37 2024
tree 4f15421efd372639daa30260f25dcc0b7d1466ba
parent 8e2af18c66a0af98b4a7e024ac95db59641b3063

QR code: Only return `SkBitmap` (no `gfx::Size`) from `GenerateBitmap`.

This CL simplifies the return type of
`qr_code_generator::GenerateBitmap` to stop returning the size (in QR
modules) of the generate QR code.  The size was only used in one place
(in `QRCodeGeneratorBubble::AddQRCodeQuietZone`).  This CL modifies that
code, so that the quiet zone can be added without knowing the size of
the generated QR code.

I treat this CL as part of the post-launch cleanup related to
go/rusty-qr-code-generator.  OTOH, I plan to handle the rest of the
"quiet zone" follow-up as a separate bug: https://crbug.com/325664342

This CL should not result in any changes in the end-to-end behavior.
OTOH, the test coverage via
//chrome/browser/share/qr_code_generator_pixeltest.cc doesn't extend to
the `QRCodeGeneratorBubble::AddQRCodeQuietZone` method, so this CL has
also been manually tested to verify if the QR code generated for
https://example.com still works fine when scanned with an Android phone.

Bug: 40263739, 325664342
Change-Id: I5d9d74457d3e19237f10a80a4a8ee26a756b7d43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5304317
Reviewed-by: Peter Williamson <petewil@chromium.org>
Reviewed-by: Gavin Williams <gavinwill@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1262771}