[code health] s/ raw_ptr / unique_ptr / in BidirectionalStreamAdapter.

The high-level goal/benefit of this CL is removal of the
`AcrossTasksDanglingUntriaged` annotation from the
`BidirectionalStreamAdapter::bidirectional_stream_` field.

Before and after this CL the following holds:

* `<anonymous namespace>::BidirectionalStreamAdapter` from
  `components/grpc_support/bidirectional_stream_c.cc` has the same
  lifetime as `grpc_support::BidirectionalStream` from
  `components/grpc_support/bidirectional_stream.h`.  In particular,
  those 2 objects are always destroyed together - their destruction is
  initiated in `BidirectionalStreamAdapter::DestroyOnNetworkThread`.  In
  other words, `BidirectionalStreamAdapter` is effectively an owner of
  `BidirectionalStream`.
* `BidirectionalStream::delegate_` field is a non-owning `raw_ptr` that
  points to `BidirectionalStreamAdapter` (which implements/subclasses
  the `BidirectionalStream::Delegate`).

Before this CL `BidirectionalStreamAdapter::bidirectional_stream_` field
was a `raw_ptr<BidirectionalStream>`.  This meant that there existed a
cycle of `raw_ptr`s that point to each other - which created a situation
where neither can be deleted without creating a dangling pointer (see
https://chromium.googlesource.com/chromium/src/+/main/docs/dangling_ptr_guide.md#cyclic-pointers).

After this CL the type of the
`BidirectionalStreamAdapter::bidirectional_stream_` field is changed
from `raw_ptr<...>` to `std::unique_ptr<...>`.  This breaks the cycle of
`raw_ptr`s, which prevents the dangling pointer detector from firing.
Furthermore, this more accurately represents lifetime/object ownership
and avoids calling a raw `delete` on `BidirectionalStream` from
`BidirectionalStream::DestroyOnNetworkThread`.

Bug: 41485225
Change-Id: I7a6cf01aecbe9cb8022d3d100fcd2421d4349966
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6480655
Reviewed-by: Adam Langley <agl@chromium.org>
Commit-Queue: Ɓukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1450253}
3 files changed
tree: b6cb12a36edb06a675566c36ddfcdfd1c859a68a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .git-blame-ignore-revs
  53. .gitallowed
  54. .gitattributes
  55. .gitignore
  56. .gitmodules
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. CPPLINT.cfg
  68. CRYPTO_OWNERS
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.