Google Git
Sign in
chromium / chromium / src / b941cb149d9d8e9621f077b66ad7fe0e454d7564
commitb941cb149d9d8e9621f077b66ad7fe0e454d7564[log] [tgz]
authorSiye Liu <siliu@microsoft.com>Thu Sep 24 23:40:45 2020
committerCommit Bot <commit-bot@chromium.org>Thu Sep 24 23:40:45 2020
treee4d206efde60801179b44d7625d199dcab2e0fb1
parentf369b5315a509101d7be59c63655a34d94f5376c [diff]
Revert change to notify input method about type change in omnibox during CJK tip.

The change to notify input method about type change in omnibox during
CJK TIP[1] causes regression that switching to a new tab will change JPN
TIP to English mode instead of Hiragana mode. The reason is that when
input method is notified about the text input type change, Windows input
service is also notified about the change. Therefore, the input mode is
changed from hiragana mode to English mode in JPN TIP.

We should only notify input service if the input type is changed to a
different value. We should also use the cached input type to find the
associated TSF document.

 [1]: I0266d9617277696ccb8bfa42ad76f9cbc3d802f3
      fe7e213cecb91264a3bd1f6aed8da3495e158963

Bug: 1108845
Bug: 1124612

Change-Id: I9ec643c7d2058695e8bc396d764ba598d6235b88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392415
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Siye Liu <siliu@microsoft.com>
Reviewed-by: Yohei Yukawa <yukawa@chromium.org>
Commit-Queue: Siye Liu <siliu@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#810350}
6 files changed
tree: e4d206efde60801179b44d7625d199dcab2e0fb1
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.