Google Git
Sign in
chromium / chromium / src / b9439522925b7f72ac3069275604742167cfb367
commitb9439522925b7f72ac3069275604742167cfb367[log] [tgz]
authorKevin Babbitt <kbabbitt@microsoft.com>Thu Aug 15 17:26:18 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Aug 15 17:26:18 2024
tree0e1bb2854ed752e02a9c8b1c2d7e057293566fd3
parentd0987d228027d2acc6ddb59e4c6166057553b23f [diff]
Templatize RuleInvalidationDataVisitor for Builder and Tracer variants

Wrap the spots where we mutate the invalidation data in compile-time
checks so that (a) they're only included in the Builder case; (b) the
Tracer can treat all the data it's looking at as const.

In some cases, calls that were directly on an InvalidationSet are
wrapped in helper methods. This is to facilitate adding tracing
alongside those calls in the Tracer case.

Several places where InvalidationSets were passed by reference also
needed to be switched to pointers. This is because there are cases
where the Tracer may not find an InvalidationSet we expect to be
there. One example is when, at the time we run the Tracer, a rule has
been added to a stylesheet but not yet indexed. In such a case, the
InvalidationSetToSelectorMap will pick up information about the new
rule as it gets indexed on the next document lifecycle update.

Bug: 337076014
Change-Id: I2151f0103628c5279485cf3fb05bd08de50e69d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5722930
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1342338}
5 files changed
tree: 0e1bb2854ed752e02a9c8b1c2d7e057293566fd3
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. CRYPTO_OWNERS
  78. DEPS
  79. DIR_METADATA
  80. LICENSE
  81. LICENSE.chromium_os
  82. OWNERS
  83. PRESUBMIT.py
  84. PRESUBMIT_test.py
  85. PRESUBMIT_test_mocks.py
  86. README.md
  87. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.