commit b969205d49cf22c487829211f97050c6e352f6fe
author Vladimir Nechaev <nechaev@chromium.org> Fri Jul 08 11:27:28 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jul 08 11:27:28 2022
tree b61263e18d1a1b552b30fcb6bbea855e58633d6a
parent fd110d02eb97240067d1d0a4517f46929e31ac9d

Filter command responses from detached CDP sessions

Sometimes, ChromeDriver can receive a command response for a command
sent to a session that has been detached. The repro steps are something
like this:

1. DevToolsClientImpl for the root session 'A' calls SendCommand and
   polls for a response.
2. An event is received for a nested DevToolsClientImpl session 'B'.
3. DevToolsClientImpl 'B' sends a nested command as part of the event
   handler and polls for a response.
4. Session 'B' detaches while DevToolsClientImpl 'B' is waiting for a
   response, so this DevToolsClientImpl stops polling and detaches.
5. Later, the browser processes the command from session 'B'. The
   CDP session is already gone, so the browser responds with an error
   message containing no "sessionId" property.
6. DevToolsClientImpl 'A' is still polling since step 1 and receives
   the error message from step 5.
7. Since the error message has no sessionId, it is handled by the
   root DevToolsClientImpl 'A'.
8. The message has an "id" that is not in DevToolsClientImpl 'A's map
   so DevToolsClientImpl::ProcessCommandResponse returns an error.
   The polling stops and the SendCommand call for step 1 fails.

The fix is to detect this condition in ProcessCommandReponse. If the
CDP reponse is a "session not found" error and the "id" is
unrecognized, then simply ignore this message and continue pumping
other messages.

The fix has been verified with the repro in the attached bug.

(cherry picked from commit f1795ca9f858cf76d98d01a4f4314b5ecb778be1)

Bug: chromium:1340174, chromedriver:4121
Change-Id: I6238de74dacb7fd2bc5e115ca5b6625232ce9ac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3658212
Commit-Queue: Brandon Walderman <brwalder@microsoft.com>
Reviewed-by: Vladimir Nechaev <nechaev@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1006507}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3751214
Commit-Queue: Vladimir Nechaev <nechaev@chromium.org>
Auto-Submit: Vladimir Nechaev <nechaev@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Cr-Commit-Position: refs/branch-heads/5060@{#1169}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}