Google Git
Sign in
chromium / chromium / src / b98a62d2ffe118f508724455e51e53ca13b610d4
commitb98a62d2ffe118f508724455e51e53ca13b610d4[log] [tgz]
authorGordon Seto <gordonseto@google.com>Thu Apr 22 00:02:45 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Apr 22 00:02:45 2021
tree343736f9852d10159aa7432658f4487debb2d068
parent3cf5ada20844d6e58a689e5c051fae09657e3c46 [diff]
Revert "[eSIM] Fix eSIM network row UI overlap."

This reverts commit ee7a7a4c5a9809fa7e903a349b076add63a8d258.

Reason for revert: Because of crbug.com/1201259, we are no longer showing the eSIM operator name on a different line from the profile name. Therefore we do not need logic to calculate the network-list-item height.

Original change's description:
> [eSIM] Fix eSIM network row UI overlap.
>
> Fix eSIM network UI overlap to appear as follows here (Note: these
> images use mock networks which in order to demonstrate the rows, I had
> display twice, but that would not happen outside of the mock I created
> for testing.)
>
> 1. Settings, flag enabled:
> https://screenshot.googleplex.com/AgbhmCHHYhccofR
> 3. Settings, flag not enabled:
> https://screenshot.googleplex.com/9cjEKioWEVAPFtz
> 4. OOBE, flag enabled:
> https://screenshot.googleplex.com/7jTUXcyAKuXamA7
> 5. OOBE, flag not enabled:
> https://screenshot.googleplex.com/8euE4Ez58hNXWer
>
> Fixed: 1192226
> Change-Id: Ibfb985ce84b70f841371cd8b86ebad334a7c5ed0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2794762
> Commit-Queue: Juliet Levesque <julietlevesque@google.com>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#868648}

Change-Id: I608eae869504e766f913cbd329620f51e243807e

Bug: 1201259
Change-Id: I608eae869504e766f913cbd329620f51e243807e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2844959
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Gordon Seto <gordonseto@google.com>
Cr-Commit-Position: refs/heads/master@{#874933}
5 files changed
tree: 343736f9852d10159aa7432658f4487debb2d068
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.