commit b9f54014d05fec233f7567e2e3f705da43ecea82
author Alex Gough <ajgo@chromium.org> Mon Jul 15 07:12:25 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jul 15 07:12:25 2024
tree 8cd384f790529db42c7ecfd02d12c562515730d7
parent facf2899e412443c5cc8528e19df14ffb91e165e

Turn iterator _!=_.end() DCHECK() into CHECK() for ['components/bookmarks', 'components/sync']

Accessing an invalid iterator can sometimes be a security
issue and these checks are cheap, so upgrade to CHECKs.
Generally these DCHECKS precede a use or erase of the
checked iterator, which if the check is invalid (ie. the
iterator == .end()) is UB.

Added checks are NotFatalUntil::M130.

`base/not_fatal_until.h` is added using tools/add_header.py,
this may result in some main-file (foo.h for foo.cc) headers
being re-sorted to be first as part `git cl format` of this CL.

For this CL instances were located with a weggli query:

```
weggli --verbose=1 --cpp \
         'DCHECK(_ != _.end());' \
      -p 'DCHECK(_.end() != _);' \
      -p 'DCHECK_NE(_, _.end());' \
      -p 'DCHECK_NE(_.end(), _);'
```

which should avoid any potentially expensive calculations
of the thing to be matched against .end().

This CL was uploaded by git cl split.

R=mastiz@chromium.org

Bug: 351745839
Change-Id: I1f18f4159a1fa69517fcbac8be2a448b48abe9a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5706310
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Auto-Submit: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1327352}