Google Git
Sign in
chromium / chromium / src / ba008f7f0cb15dd8c14cd393ba516cd979e71a55
commitba008f7f0cb15dd8c14cd393ba516cd979e71a55[log] [tgz]
authorvikas soni <vikassoni@chromium.org>Thu Jan 02 18:07:09 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jan 02 18:07:09 2025
tree6b874231865d7cd2ea85cf3eac9545c1d7b4050f
parent0866d0eb4c37329ff2502d2410f6c4f700c1789d [diff]
[MappableSI] Use CPU_ONLY_READ_WRITE for CrOs media capture.

As a part of MappableSI, we are replacing GMB usage with MappableSI.
Creating a MappableSI for R8 format in media capture code currently
fails in service side code[1]. This is because creating a
NativePixmap as part of OzoneImageBacking creation will fail as
the underlying buffer is not texturable.

Also for media capture code irrespective of the format, we don't really
need to hold the GMB handle in the service side SharedImage backing
anyways since capture code only need the GMB handle to map. Handle is
then sent to renderer which actually creates a shared image which will
be used in the GPU process.

Hence use SHARED_IMAGE_USAGE_CPU_ONLY_READ_WRITE which instructs the
service side that a NativePixmap inside the SharedImage is not
necessary for this use case. This allows skipping the service side
checks for texturable format.

[1] https://source.chromium.org/chromium/chromium/src/+/main:ui/gfx/linux/gbm_wrapper.cc;drc=5d0194cbc9cddc2ad096da32f16d7d1eac5d4a34;l=410

Bug: 40264379, 382679374, 370760466
Change-Id: Ie1263454ca3e857efe521d1fe282f399d3db899f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072273
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Auto-Submit: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401487}
3 files changed
tree: 6b874231865d7cd2ea85cf3eac9545c1d7b4050f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.