Google Git
Sign in
chromium / chromium / src / ba37e3c70cee97aaee21ce9810006f8e86e5a40c
commitba37e3c70cee97aaee21ce9810006f8e86e5a40c[log] [tgz]
authorAida Zolic <aidazolic@chromium.org>Tue May 30 13:46:37 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue May 30 13:46:37 2023
tree23fcd8b8c0ca32e8d0346f53c94f9b7be16e82a3
parentdfa0a850a566a7518a76a886cab1beb121c83c11 [diff]
dlp: Split block and warn files dialogs

Splits FilesPolicyDialog into two subclasses for warning and block
restriction levels, i.e. warning or error dialogs. The warning dialog
can only be shown for a single policy at a time, while the error dialog
can combine blocked files from both DLP and Enterprise Connectors.

Currently only the constructors and some methods are extracted to the
child classes, but in the future more of the setup will be moved from
the base, which will only handle setting up the views etc, as the text
used in the dialog should depend on its type.

R=ayaelattar@chromium.org

Fixed: b:284287312
Change-Id: If2df288f0fed7b10b227afe77ec3dc58ba684eef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4570510
Reviewed-by: Aya Elsayed <ayaelattar@chromium.org>
Commit-Queue: Aya Elsayed <ayaelattar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1150522}
9 files changed
tree: 23fcd8b8c0ca32e8d0346f53c94f9b7be16e82a3
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.