| commit | ba8ed7971272f5a49685a623f8d310805fb9c8e7 | [log] [tgz] |
|---|---|---|
| author | Radu Nitescu <radunitescu@google.com> | Mon Mar 24 15:42:15 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Mar 24 15:42:15 2025 |
| tree | 67da9a072a8a4d6a01b0a30630e775b167d11131 | |
| parent | 1cc80bfaf5a2bcb09ac67b95d5aea5a2550ab2e0 [diff] |
[iOS][LO] Prevent premature self deallocation in detents manager Invoking `lensOverlayDetentsManagerDidChangeDimensionState:` may lead to the overlay's destruction, consequently deallocating both the overlay's results page presented and its owned detents manager. A use-after-free condition will occur during the remaining execution statements in the detentss manager's `reportDimensionChangeIfNeeded`. To mitigate this, increase the retain count by maintaining a strong reference in the scope of the method that informs the delegate. Diagram of the flow: https://screenshot.googleplex.com/ACACm2YPgKxcpCy.png Fixed: 403224762 Change-Id: Ia2bc2419599c221d02ab94e06c4de3e887075eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6387096 Commit-Queue: Radu Nitescu <radunitescu@google.com> Reviewed-by: Christian Xu <christianxu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1436871}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.
