Google Git
Sign in
chromium / chromium / src / ba8f9ae3ce51a05e484d3096b54d5db47161de37
commitba8f9ae3ce51a05e484d3096b54d5db47161de37[log] [tgz]
authorAlan Cutter <alancutter@chromium.org>Thu Nov 11 05:25:10 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Nov 11 05:25:10 2021
tree64d9f92a1d1f2f370a9af8339d5dba94976da4a3
parent77c368a7adcbe20e0be5c86dc7a5c25d5a28e93a [diff]
System-apps: Dedupe LaunchAndNavigateSystemWebApp() code with ash and core

This refactor is a follow up to:
https://chromium-review.googlesource.com/c/chromium/src/+/3226291

This CL:
 - Merges SystemWebAppDelegateBase back up into SystemWebAppDelegate.
 - Moves the LaunchAndNavigateSystemWebApp() default implementation
   into a separate system_web_app_delegate_ui_impl.cc under ui/.

This is to ensure the system web app launch path is accessible outside
of ash and is being covered by our core test code.

Change-Id: I0f3c68b7760b3713b9ffb44a3ed76f3b07d246b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3272118
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Dominic Schulz <dominicschulz@google.com>
Reviewed-by: Jiewei Qian  <qjw@chromium.org>
Cr-Commit-Position: refs/heads/main@{#940664}
56 files changed
tree: 64d9f92a1d1f2f370a9af8339d5dba94976da4a3
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.