Google Git
Sign in
chromium / chromium / src / ba9bdd73d1e1a94e347e5c99375fa557631aee4a
commitba9bdd73d1e1a94e347e5c99375fa557631aee4a[log] [tgz]
authorOlesia Marukhno <olesiamarukhno@google.com>Thu Apr 08 08:54:29 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Apr 08 08:54:29 2021
treef8ae423e016e0e697eedbf1be7455002acde8167
parent71f9974a445c0df2e54bd0a7a83fcd74727f1d0b [diff]
Enabled pixel tests for permission chip

TestBrowserUi supports verifying pixel UI for dialogs (windows) only.
In this CL I added method that can verify UI for a view
(BrowserSkiaGoldPixelDiff supports taking screenshots and comparing
views). I also used this new methods in browser test for permission chip
button in the omnibox.

To ensure that correct screenshot is taken each time (with chip expanded
and both icon and text shown), I added logic to force expand the chip
for tests.

Also, I added PermissionPromptBubbleViewBrowserTest to the filter file,
it wasn't there before and pixel comparison wasn't performed for it.

Change-Id: I4c08f6bd5d98ea0c9f645f51fd2290f50e718806
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2780669
Reviewed-by: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com>
Cr-Commit-Position: refs/heads/master@{#870420}
6 files changed
tree: f8ae423e016e0e697eedbf1be7455002acde8167
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.