| commit | badc704f1939da9933d904adb23bea44f93b6c5f | [log] [tgz] |
|---|---|---|
| author | Kelvin Jiang <kelvinjiang@chromium.org> | Fri Jun 27 01:34:27 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jun 27 01:34:27 2025 |
| tree | ee6964516c240d039a21f34b2252b6f135d455f4 | |
| parent | 82217425317588991153753d0f876453aa6c1711 [diff] |
[WAR, DNR] Fix unsafe redirect error to web accessible resource Error was observed on web pages that had a service worker for fetching subresources. This caused the page to use the SharedURLLoaderFactory which never bypasses renderer level redirect checks. Combine that with the fact that the request's initiator was not passed down into the renderer's redirect check + a redirect to an extension's Web Accessible Resource that required the initiator to check if it was a safe redirect, that led to the UNSAFE_REDIRECT error observed. Fix involved adding the request's initiator to RedirectInfo which can then be used in the renderer. Bug: 375395102 Change-Id: I84a526c165847cfe390978d7133022aee25dd303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6580522 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by: Solomon Kinard <solomonkinard@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1479568}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.