Google Git
Sign in
chromium / chromium / src / baeed16a74641aade69498304f11e112138e7af5
commitbaeed16a74641aade69498304f11e112138e7af5[log] [tgz]
authorTheodore Olsauskas-Warren <sauski@google.com>Wed Jul 26 09:26:19 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jul 26 09:26:19 2023
tree38583796445658e3c1135d1da6afcc788b73656d
parent9d7163aa9aad44846b3e1025c2191c47fdfe9ddb [diff]
Browsing Data Model: Ensure MediaLicense access is reported correctly

The KeySystemConfigSelector was checking whether kLocalStorage access
was available to determine whether key access was allowed. This
resulted in an access report to local storage being ultimately
received by the PageSpecificContentSettings.

Media Licenses are a Quota managed type, and so to be correctly
represented in the in-context UI (and correctly deleted) they should
be reported as such.

This CL changes the KeySystemConfigSelector to check for IndexedDB
access instead, which ultimately presents as an access to quota
managed storage, and so license information will be deleted
correctly.

CL also introduces a debugging string into the BrowsingDataModel
test util to make determining the difference between expected and
actual entries simpler to debug.

Bug: 1271155
Change-Id: I6889b7cadc68d7a7ae8cdd9a960ac13696e905eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4685559
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1175315}
6 files changed
tree: 38583796445658e3c1135d1da6afcc788b73656d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.