Google Git
Sign in
chromium / chromium / src / baef5349314231bf93014317bb38d76caf3d8392
commitbaef5349314231bf93014317bb38d76caf3d8392[log] [tgz]
authorKeren Zhu <kerenzhu@chromium.org>Fri May 23 19:42:08 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri May 23 19:42:08 2025
tree71d82984d01d93dd36d63c29143a7cc9cff945af
parentaf1fc7a465a7bca6a98f62f4804e7919d1b6d387 [diff]
glic: use desktop widget for web modals

Using desktop widgets allows the web modal dialogs to extend beyond the
boundary of the glic window on Windows.

This also kicks off the larger project that intends to use desktop
widgets everywhere on desktop aura.

screencast:
https://drive.google.com/file/d/1TItT0ZqSfkYtvpWHMDpimKfaBftq1q0H/view?usp=sharing.
It hacks to invoke DesktopDataControlsDialog during glic startup.

Investigation doc (internal):
https://docs.google.com/document/d/1rY7OVmEry6-SjuL8bWABXxJaQofrOphVblNcqoTamcg/edit?pli=1&tab=t.0#heading=h.9t8nfprvrbr2

Bug: b:409382820, 346974105
Change-Id: I15ff283dd46bef1519e64510e4ea6594131fa767
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6578297
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464928}
8 files changed
tree: 71d82984d01d93dd36d63c29143a7cc9cff945af
  1. .github/
  2. android_webview/
  3. apps/
  4. ash/
  5. base/
  6. build/
  7. build_overrides/
  8. buildtools/
  9. cc/
  10. chrome/
  11. chromecast/
  12. chromeos/
  13. codelabs/
  14. components/
  15. content/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. SECURITY_OWNERS
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.