Google Git
Sign in
chromium / chromium / src / bafec2415e83c4712e299c0ce1dadb202b25bbf9
commitbafec2415e83c4712e299c0ce1dadb202b25bbf9[log] [tgz]
authorDavid Maunder <davidjm@chromium.org>Wed Mar 16 18:31:22 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Mar 16 18:31:22 2022
treecc901aa7df87b1fe90f4d12cb8fdf36616a4b672
parente6716cdcdb4c27b3b337976c9c7145c2b0b41989 [diff]
Retrieve CriticalPersistedTabData attributes in mapper

Currently we deserialize the FlatBuffer in the mapper (which
is used on the same I/O thread as the file read) and then pull
the attributes off the FlatBuffer in the TabImpl constructor.
I am observing a small number of crashes on
flatBuffer.webContentsStateBytesAsByteBuffer() by which point it is
too late to fall back to TabState or re-create the Tab. This CL
moves field acquisition for the FlatBuffer to the mapper which means
if something goes wrong we can return a null
SerializedCriticalPersistedTabData which will in turn force the code
to fallback to TabState (and failing that re-create the Tab).

Bug: 1302098
Change-Id: I183760f80dfe993dc3a1b67aeaa151eed869db57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3527607
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#981752}
3 files changed
tree: cc901aa7df87b1fe90f4d12cb8fdf36616a4b672
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.