Google Git
Sign in
chromium / chromium / src / bb1f068a10de9d08b4180de0c596882024d89a58
commitbb1f068a10de9d08b4180de0c596882024d89a58[log] [tgz]
authorFinnur Thorarinsson <finnur@chromium.org>Tue Nov 19 21:36:08 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Nov 19 21:36:08 2024
tree0a8fbccab378a5e1581fb4072f98c4133006a9fd
parent90ec8514e7dfcdd3ead100d80017baad60505e5b [diff]
[NavCapture]: Migrate away from Find[Installed]AppWithUrlInScopes.

This is an intermediary no-op step where we switch calls to
Find[Installed]AppWithUrlInScopes over to calls to
FindBestAppWithUrlInScopes (which is what these functions do
internally).

This change is for directory:
chrome/browser/banners

Planned (but beyond the scope of this CL) is an effort to
evaluate all call sites of FindBestAppWithUrlInScopes for
correctness and introduce new helpers, that hopefully will
be more resistant to incorrect use.

Design doc: https://docs.google.com/document/d/14JPgYUVX8ECAMdXlp6GwXP-ucXnIIPXjTfxWt-WINLo/edit?usp=sharing

This CL was uploaded by git cl split.

R=cmp@chromium.org

Bug: 340952100
Change-Id: Ifb0d8a2b1235c6e7886ac5e42718713dfb62bed8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6033420
Commit-Queue: Dibyajyoti Pal <dibyapal@chromium.org>
Reviewed-by: Dibyajyoti Pal <dibyapal@chromium.org>
Auto-Submit: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1385228}
1 file changed
tree: 0a8fbccab378a5e1581fb4072f98c4133006a9fd
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.